Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing ouu discrete uncertain parameters #1018

Merged
merged 9 commits into from
Apr 19, 2022
Merged

Testing ouu discrete uncertain parameters #1018

merged 9 commits into from
Apr 19, 2022

Conversation

dghoshal-lbl
Copy link
Collaborator

Summary/Motivation:

  • Adds a new module to automate testing example workflow: OUU with Discrete Uncertain Parameters Only.
  • Goal is to also improve the code-coverage for the automated tests.

Changes proposed in this PR:

  • A new test module test_ouu.py in foqus_lib/gui/tests/ directory.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 29, 2022
@lbianchi-lbl lbianchi-lbl mentioned this pull request Apr 7, 2022
Open
@lbianchi-lbl
Try using another handler for modal dialog
c6dbced 
Try alternative strategy to handle modal dialogs


Run Black


Try with alternative strategy to handle main window close event


Run Black


Try if using --pyargs makes a difference


Try adding explicit cleanup for qtbot instance
@lbianchi-lbl lbianchi-lbl linked an issue Apr 12, 2022 that may be closed by this pull request
FOQUS GUI Testing: OUU Discrete Uncertain Parameters #1011
Closed
8 tasks
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.56%. Comparing base (824c237) to head (b893e5d).
Report is 104 commits behind head on master.

Files Patch % Lines
pytest_qt_extras.py 84.90% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   30.77%   32.56%   +1.79%     
==========================================
  Files         161      161              
  Lines       35791    35844      +53     
  Branches     6041     6047       +6     
==========================================
+ Hits        11013    11673     +660     
+ Misses      23964    23246     -718     
- Partials      814      925     +111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lbianchi-lbl
lbianchi-lbl approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and finally we got all the (unrelated) test failures under control.

@lbianchi-lbl lbianchi-lbl merged commit 029fdee into CCSI-Toolset:master Apr 19, 2022
lbianchi-lbl pushed a commit that referenced this pull request Apr 19, 2022
@dghoshal-lbl @lbianchi-lbl
Testing ouu discrete uncertain parameters (#1018)
65da3f3 
* Running OUU tutorial-1 example: exception doing Run OUU

* try2: combining the workflow steps together

* test module for OUU Example 1 workflow

* test module for OUU Example 1 workflow- edit comment

* fix formatting

* Try using another handler for modal dialog

Try alternative strategy to handle modal dialogs

Run Black

Try with alternative strategy to handle main window close event

Run Black

Try if using --pyargs makes a difference

Try adding explicit cleanup for qtbot instance

* Restore signal replacement functionality used by test_ml_ai.py

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
(cherry picked from commit 029fdee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@boverhof boverhof Awaiting requested review from boverhof

Assignees
No one assigned
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FOQUS GUI Testing: OUU Discrete Uncertain Parameters
3 participants
@dghoshal-lbl @lbianchi-lbl @ksbeattie